Part of the fun when reading is working out things about a character from the clues the writer gives you so give your future readers room to do just that. Don't spell out everything.
Your characters' flaws and virtues should be nice and clear too. You want your readers cheering your characters on!